Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs fix and improvement for 0.1.8 #21

Merged
merged 9 commits into from
Oct 1, 2020
Merged

Bugs fix and improvement for 0.1.8 #21

merged 9 commits into from
Oct 1, 2020

Conversation

lamhoangtung
Copy link
Contributor

@lamhoangtung lamhoangtung added the enhancement New feature or request label Oct 1, 2020
@lamhoangtung lamhoangtung requested a review from hiro-v October 1, 2020 11:44
@lamhoangtung lamhoangtung self-assigned this Oct 1, 2020
hiro-v
hiro-v approved these changes Oct 1, 2020
View reviewed changes
Copy link

@hiro-v hiro-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many improvements. Keep it up!!! 👌🥺🙄🤟🙆

@codecov
Copy link

codecov bot commented Oct 1, 2020 •
edited
Loading

Codecov Report

Merging #21 into master will increase coverage by 4.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   49.46%   54.12%   +4.66%     
==========================================
  Files          44       44              
  Lines        3613     3597      -16     
==========================================
+ Hits         1787     1947     +160     
+ Misses       1826     1650     -176
Impacted Files Coverage Δ
mlchain/cli/init.py 100.00% <ø> (+15.38%) ⬆️
mlchain/cli/main.py 100.00% <ø> (+6.66%) ⬆️
mlchain/server/__init__.py 100.00% <ø> (+56.25%) ⬆️
mlchain/workflows/parallel.py 67.91% <ø> (+0.26%) ⬆️
mlchain/workflows/pipeline.py 83.60% <100.00%> (+58.40%) ⬆️
mlchain/base/serializer.py 61.34% <0.00%> (+1.26%) ⬆️
mlchain/workflows/background.py 87.50% <0.00%> (+3.75%) ⬆️
mlchain/base/exceptions.py 100.00% <0.00%> (+11.11%) ⬆️
mlchain/workflows/task.py 81.25% <0.00%> (+14.58%) ⬆️
mlchain/base/serve_model.py 51.66% <0.00%> (+18.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c52cd...d2d8c04. Read the comment docs.

@lamhoangtung lamhoangtung merged commit c8ad8e0 into master Oct 1, 2020
lamhoangtung added a commit that referenced this pull request Dec 26, 2020
@lamhoangtung @meocong
Sentry with other improvement for 0.1.9 (#29)
e9e08dd 
* 🐛 Bugs fix and improvement for 0.1.8 (#21)

* Resolve merge conflict

* Compress CSS

* Compressed js

* Compress more html

* Detached SVG and compress final HTML file

* potential fix for #20

* Minor pipeline bug fixed

* Minor coverage test increase

* 🔖 Update mlconfig 🔖

Env var is now on top of priority in mlconfig

* 🚀 🚀 🚀 Update mlchain 0.1.9 🚀 🚀 🚀

- Sentry integration. Fixed #28
- Update better interface for mlconfig.yaml
- Put env on the most priority
- Handle some exceptions

* Update requirements + Fixed sentry when no dsn

* 🐛 Higher Priority for Sentry config using env vars + Fixed requirements for Python 3.6 🐛

* 🎉 🎉 🎉 Handle exception + Fixed Sentry break Gunicorn + Better default config🎉 🎉 🎉

Co-authored-by: Hoang Viet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiro-v hiro-v hiro-v approved these changes

Assignees

@lamhoangtung lamhoangtung

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyYAML Breaking Dependency Compress Swagger HTML for smaller web asset footprint
2 participants
@lamhoangtung @hiro-v