Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for MLChain 0.1.9 #30

Merged
merged 31 commits into from
Dec 29, 2020
Merged

Improvement for MLChain 0.1.9 #30

merged 31 commits into from
Dec 29, 2020

Conversation

lamhoangtung
Copy link
Contributor

@lamhoangtung lamhoangtung commented Dec 29, 2020

lamhoangtung and others added 30 commits September 29, 2020 18:19
Env var is now on top of priority in mlconfig
- Sentry integration. Fixed #28
- Update better interface for mlconfig.yaml
- Put env on the most priority
- Handle some exceptions
@lamhoangtung lamhoangtung requested a review from meocong December 29, 2020 00:30
@lamhoangtung lamhoangtung added the enhancement New feature or request label Dec 29, 2020
@lamhoangtung lamhoangtung self-assigned this Dec 29, 2020
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #30 (bde3fc5) into master (12c52cd) will increase coverage by 5.93%.
The diff coverage is 56.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   49.46%   55.39%   +5.93%     
==========================================
  Files          44       47       +3     
  Lines        3613     3809     +196     
==========================================
+ Hits         1787     2110     +323     
+ Misses       1826     1699     -127     
Impacted Files Coverage Δ
mlchain/base/serve_model.py 51.68% <ø> (+18.34%) ⬆️
mlchain/base/wrapper.py 33.33% <0.00%> (-1.67%) ⬇️
mlchain/cli/main.py 100.00% <ø> (+6.66%) ⬆️
mlchain/cli/mlchain_server.py 0.00% <0.00%> (ø)
mlchain/server/__init__.py 100.00% <ø> (+56.25%) ⬆️
mlchain/server/flask_server.py 56.38% <0.00%> (+0.73%) ⬆️
mlchain/server/grpc_server.py 35.08% <0.00%> (ø)
mlchain/server/quart_server.py 26.23% <0.00%> (+0.29%) ⬆️
mlchain/cli/run.py 62.86% <41.66%> (-2.44%) ⬇️
mlchain/server/view.py 62.41% <50.53%> (+2.91%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c52cd...bde3fc5. Read the comment docs.

@meocong meocong merged commit e48cc3a into master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants