-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and improvement for mlchain 0.2 #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mlchain API + fixed swagger for Starlette
* Retry build matrix * Temporary turn off old windows CI hack * hmmm * just a test * lol ? * Background now can wait for result with BackgroundTask.wait() * Turn build and test stage back on * hmmm * Trying to migrate CI to github action * Limit click to 7xx for uvicorn * Don't install uvloop for python 3.6 * Try new ways to parse requirements * Force uvloop==0.14.0 * More complicated uvloop req * set_start_method("fork") for mac OS with python 3.8+ * Fix security vulnerability dependencies * Trying to speed up Linux 3.6 with conda * Minor typo fixed * Add release workflows * MInor tag format fixed * Minor README update * Simplify install process * Don't set fork on windows * Hope for more stable mac test * What if I used conda for every job * Minor windows fix * Don't use conda for windows * My bad * Minor CI log * New kind of test call, no discover * Typo fixed * Avoid test server running forever * Move to pytest instead of unittest * What if we don't test the mlchain pipeline
* Support header for mlchain client * Support header for mlchain client and remove comment * add type checking * add type checking * ignore scripts folder * ignore scripts folder * Change default None header to {}
Fix priority of workers and threads Update requirements
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 55.39% 54.11% -1.29%
==========================================
Files 47 46 -1
Lines 3809 4038 +229
==========================================
+ Hits 2110 2185 +75
- Misses 1699 1853 +154
Continue to review full report at Codecov.
|
meocong
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include many changes for mlchain 0.2.2 release, including:
Also with better log, description, exception here and there for a better user experience.