Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvement for mlchain 0.2 #43

Merged
merged 44 commits into from
Jun 18, 2021
Merged

Fixes and improvement for mlchain 0.2 #43

merged 44 commits into from
Jun 18, 2021

Conversation

lamhoangtung
Copy link
Contributor

@lamhoangtung lamhoangtung commented Jun 18, 2021

This PR include many changes for mlchain 0.2.2 release, including:

Also with better log, description, exception here and there for a better user experience.

meocong and others added 30 commits December 29, 2020 17:59
* Retry build matrix

* Temporary turn off old windows CI hack

* hmmm

* just a test

* lol ?

* Background now can wait for result with BackgroundTask.wait()

* Turn build and test stage back on

* hmmm

* Trying to migrate CI to github action

* Limit click to 7xx for uvicorn

* Don't install uvloop for python 3.6

* Try new ways to parse requirements

* Force uvloop==0.14.0

* More complicated uvloop req

* set_start_method("fork") for mac OS with python 3.8+

* Fix security vulnerability dependencies

* Trying to speed up Linux 3.6 with conda

* Minor typo fixed

* Add release workflows

* MInor tag format fixed

* Minor README update

* Simplify install process

* Don't set fork on windows

* Hope for more stable mac test

* What if I used conda for every job

* Minor windows fix

* Don't use conda for windows

* My bad

* Minor CI log

* New kind of test call, no discover

* Typo fixed

* Avoid test server running forever

* Move to pytest instead of unittest

* What if we don't test the mlchain pipeline
@lamhoangtung lamhoangtung added the enhancement New feature or request label Jun 18, 2021
@lamhoangtung lamhoangtung self-assigned this Jun 18, 2021
@lamhoangtung lamhoangtung requested a review from meocong June 18, 2021 04:32
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #43 (9adc4f2) into master (e48cc3a) will decrease coverage by 1.28%.
The diff coverage is 45.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   55.39%   54.11%   -1.29%     
==========================================
  Files          47       46       -1     
  Lines        3809     4038     +229     
==========================================
+ Hits         2110     2185      +75     
- Misses       1699     1853     +154     
Impacted Files Coverage Δ
mlchain/base/wrapper.py 90.47% <0.00%> (+57.14%) ⬆️
mlchain/server/grpc_server.py 35.08% <ø> (ø)
mlchain/storage/__init__.py 100.00% <ø> (ø)
mlchain/storage/base.py 100.00% <ø> (+57.14%) ⬆️
mlchain/base/converter.py 42.97% <13.27%> (-8.75%) ⬇️
mlchain/server/format.py 50.72% <19.04%> (-4.74%) ⬇️
mlchain/server/starlette_server.py 43.72% <43.72%> (ø)
mlchain/server/base.py 61.49% <45.45%> (-14.93%) ⬇️
mlchain/server/flask_server.py 60.24% <47.25%> (+3.85%) ⬆️
mlchain/base/serve_model.py 52.06% <50.00%> (+0.38%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48cc3a...9adc4f2. Read the comment docs.

@lamhoangtung lamhoangtung merged commit 73d9951 into master Jun 18, 2021
@lamhoangtung lamhoangtung deleted the starllete branch June 18, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants