Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very Minor But Annoying Language Changes #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FireController1847
Copy link

Okay, I get it, it's installing Minecraft. But that's not what your console says! It says downloading Minecraft. It's so minor, but the issue is it can make users question why it's taking so long (particularly tech savvy ones). For example, if you have an SSD you expect install time to be short, but if you have crap internet you expect download time to be long. Changing these makes a lot more sense than "installing" for this specific instance.

Well technically you're downloading & installing, but stating "downloading" would make more sense on why it takes so long. Like, "I HAVE AN SSD WHY IS *INSTALLING* TAKING SO LONG"
@Pyker
Copy link
Member

Pyker commented Jun 27, 2020

I haven't taken any action on this PR because the exact mechanics of how tasks in the laucher are kinda weird (and merging this would invalidate the other translations).

Looking at the code now, it doesn't just install or just download, it downloads things (if necessary) and installs them. That said, I'm not sure what to change this to.

@FireController1847
Copy link
Author

Maybe instead of just using one message for both, you could use two messages: one saying downloading during the download, and one saying installing during the install. I mean, I made this PR a long time ago so tbh I don't know how outdated it is lol, but I just feel like separating the two will help solve a little bit of confusion as to, say, "I have really slow internet but a super fast SSD, why is it taking forever to install?" Of vice versa "I have really fast internet but a slow HDD why is it taking forever to download?"

@Pyker
Copy link
Member

Pyker commented Jun 27, 2020

To be fair, it downloads to the hard drive, so if that's slow then the download will also be slow, regardless of how fast your internet might be.

@FireController1847
Copy link
Author

Yeah I realized that as I was typing it lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants