-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 8 accessibility #387
base: master
Are you sure you want to change the base?
Project 8 accessibility #387
Conversation
Hi Erika, great job with the semantic HTML elements, like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well defined form, descriptive alt tags as well as sufficient contrasts 🥳
Nice that you’ve used ARIA labels and roles, but some elements have incorrect roles.img and a tags respectively since the img and a tags handle these roles inherently. However, adding ARIA labels directly to links and buttons could improve support for screen readers.
PS. Noticed your hamburger is a bit buggy on small phones |
Updated business site with accessibility.