Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shanti Studio | UX collab | Week 12 | Eliane #54

Open
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

El1an3
Copy link

@El1an3 El1an3 commented Apr 28, 2024

Netlify link

https://shanti-studio.netlify.app/

Collaborators

none

Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Eliane, and big congrats on finishing this project all alone ✨ You worried about it not to be perfect, well you got really close to that, and in 1 week on your own..super impressive! The site looks very close to the design and followed our requirements. How did you like Styled Components? Seems like you tackled it in the right way and implemented a great result! How cool you created a carousel using an external library! Now the design is not pixel perfect, but that's okay, here's a little things that can be taken into consideration to improve it even further if you want:

  • use always format.svg for images not.jpg, this will ensure HQ on any screen size
  • footer: divs are not centre aligned. You can easily add “margin: auto” to have the text vertically entered inside the div
  • elements within a flex-box, to center-align them just add: `align-items: center;

You nailed it, kudos!! ⭐ 👑 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants