-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design collab with Nella, Jennifer (UX) and Cholpon #65
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the project!
You've followed the design and made good use of components. You've met all requirements.
However, make sure to not leave your code "sloppy" when it comes to formatting the files. Keep the indentation clean and consistent.
⭐️
width: 141px; | ||
height: 43px; | ||
flex-shrink: 0; | ||
padding: 56px 0 32px 0; | ||
margin: 0 auto; | ||
`; | ||
|
||
const InsamlingsLogo = styled.img` | ||
width: 219px; | ||
height: 54px; | ||
flex-shrink: 0; | ||
padding-bottom: 46px; | ||
margin: 0 auto; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
@media (min-width: 768px) { | ||
position: absolute; | ||
top: 0; | ||
left: 0; | ||
width: 100%; | ||
height: 90%; | ||
object-fit: cover; | ||
z-index: -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
margin: 0 auto; | ||
padding-bottom: 32px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
color: #545F71; | ||
font-size: 24px; | ||
font-family: 'Cabin'; | ||
word-wrap: 'break-word'; | ||
margin: 16px 0 0 0; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
color: #1c7d79; | ||
font-size: 24px; | ||
font-weight: 400; | ||
font-family: "Schoolbell"; | ||
word-wrap: break-word; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
Netlify link
https://christmascharity.netlify.app/
Collaborators
@nella-x