Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design collab with Nella, Jennifer (UX) and Cholpon #65

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

cholpoun
Copy link

@cholpoun cholpoun commented Nov 9, 2024

Netlify link

https://christmascharity.netlify.app/

Collaborators

@nella-x

@JennieDalgren JennieDalgren self-assigned this Nov 14, 2024
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the project!
You've followed the design and made good use of components. You've met all requirements.

However, make sure to not leave your code "sloppy" when it comes to formatting the files. Keep the indentation clean and consistent.

⭐️

Comment on lines +7 to +20
width: 141px;
height: 43px;
flex-shrink: 0;
padding: 56px 0 32px 0;
margin: 0 auto;
`;

const InsamlingsLogo = styled.img`
width: 219px;
height: 54px;
flex-shrink: 0;
padding-bottom: 46px;
margin: 0 auto;
`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Comment on lines +22 to +29
@media (min-width: 768px) {
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 90%;
object-fit: cover;
z-index: -1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Comment on lines +35 to +36
margin: 0 auto;
padding-bottom: 32px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Comment on lines +18 to +23
color: #545F71;
font-size: 24px;
font-family: 'Cabin';
word-wrap: 'break-word';
margin: 16px 0 0 0;
`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Comment on lines +41 to +46
color: #1c7d79;
font-size: 24px;
font-weight: 400;
font-family: "Schoolbell";
word-wrap: break-word;
`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants