labyrinth Eliane &Vittoria #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second fetch
started styling, added loading page
responsiveness, added new message for end of game, not fully working
HIPPIEKICK
approved these changes
Apr 26, 2024
Comment on lines
+35
to
+41
| <input | ||
| className="home-input" | ||
| type="text" | ||
| placeholder="Enter username" | ||
| value={inputUsername} | ||
| onChange={handleUsernameChange} | ||
| /> |
There was a problem hiding this comment.
Maybe add a maxLength on this since it's affecting your UI (in the paragraph)
There was a problem hiding this comment.
Plus make sure the input is not empty because then your app breaks
Comment on lines
+18
to
+36
| useEffect(() => { | ||
| const handleKeyPress = (e) => { | ||
| if (e.key === 'ArrowUp') { | ||
| handleDirectionClick({ type: 'move', direction: 'North' }) | ||
| } else if (e.key === 'ArrowDown') { | ||
| handleDirectionClick({ type: 'move', direction: 'South' }) | ||
| } else if (e.key === 'ArrowLeft') { | ||
| handleDirectionClick({ type: 'move', direction: 'West' }) | ||
| } else if (e.key === 'ArrowRight') { | ||
| handleDirectionClick({ type: 'move', direction: 'East' }) | ||
| } | ||
| } | ||
|
|
||
| document.addEventListener('keydown', handleKeyPress) | ||
| return () => { | ||
| document.removeEventListener('keydown', handleKeyPress) | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []) |
| const [showMap, setShowMap] = useState(false) | ||
| // added style based on coordinates | ||
| useEffect(() => { | ||
| console.log('Coordinates:', gameData.coordinates) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://maze-game-adventure.netlify.app/
Collaborators
[vittoriamatteoli, El1an3]