Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technigo-w14-project-mongo-api #497

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

schouenkes
Copy link

mongoose.connect(mongoUrl);
mongoose.Promise = Promise;

const Author = mongoose.model("Author", {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressed with the advanced schema you made!

@@ -1,23 +1,103 @@
import express from "express";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im very impressed with your code. I can't really find anything to give constructive feedback about ... :)

Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Maja, I see no issues in the code but I couldn't test the endpoints, I gave an internal error back after trying several times. The "/" path is working though.I can't see from the code how was the DB populated, did you test it and did you manage to get the right responses back ?Let me know thanks :)

@schouenkes
Copy link
Author

I have added the IPs from Render to the Mongo DB whitelist, that is probably why it didn't work correctly before. It should work as supposed to now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants