Jonas Portfolio #397
Open
Jonas Portfolio #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maryyy-ux
reviewed
Nov 10, 2024
src/components/project/Project.css
Outdated
| align-items: center; | ||
| } | ||
|
|
||
| @media (min-width: 768px) { |
There was a problem hiding this comment.
Smart media queries! Love that! Everything under control and defined. Congrats!
| @@ -0,0 +1,36 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
Suggested change
| import React from "react"; | |
| import React from "react"; |
Oops, maybe this is a missing pillow. Seems its not required.
JennieDalgren
requested changes
Nov 12, 2024
|
@JennieDalgren I have updated the design to better align with the provided mockup. Changes have been made for mobile, tablet, and desktop views. :) |
Maryyy-ux
approved these changes
Nov 18, 2024
HIPPIEKICK
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Please go through all spacings another time, here's an example of a thing that is not according to design, it should be 128px top and 64px bottom. Apart from that - check the dark/light mode rules (might be Vite's default) because it looks broken in some places with dark mode on.
HIPPIEKICK
requested changes
Jan 8, 2025
|
|
||
| color-scheme: light dark; | ||
| color: white; | ||
| background-color: #242424; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL: https://jonashellstrom-portfolio.netlify.app/