Week 15: To do app #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Hi Kelly! You're off to a really good start this week and your Zustand store has been nicely set up. Next step is to get rid of the prop drilling and implement the functions you've defined in your store instead.
Changes required
- Use Zustand for global state management instead of passing props
Other things to just think about going forward
- Don't forget to add labels to form elements
- If you're struggling with the weekly topic, try focusing on that more than stretch goals (however, it's nice that you're challening yourself with thas as well).
- Another thing I'd like to ask you is to stay consistent with whether or not you're using arrow functions or the function keyword.
Comment on lines
+104
to
+133
| <Select | ||
| value={category} | ||
| onChange={(e) => setCategory(e.target.value)} | ||
| > | ||
| <option value="">Select a Category</option> | ||
| {availableCategories.map((cat, index) => ( | ||
| <option key={index} value={cat}> | ||
| {cat} | ||
| </option> | ||
| ))} | ||
| </Select> | ||
| )} | ||
| <Input | ||
| type="text" | ||
| placeholder="Category" | ||
| value={category} | ||
| onChange={(e) => setCategory(e.target.value)} | ||
| /> | ||
| <Input | ||
| type="text" | ||
| placeholder="Task" | ||
| value={task} | ||
| onChange={(e) => setTask(e.target.value)} | ||
| /> | ||
| <Input | ||
| type="date" | ||
| value={date} | ||
| onChange={(e) => setDate(e.target.value)} | ||
| /> | ||
| <SubmitButton onClick={handleSubmit}>Add Task</SubmitButton> |
There was a problem hiding this comment.
Don't forget the form element as well as labels for form elements. This will improve accessibility
|
@HIPPIEKICK I hope this will resolve the last required changes :')) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://do-it-to-do.netlify.app/
Still figuring out the global state:'(