Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-Do-Project - Elina Eriksson Hult #31

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

ElinaEH
Copy link

@ElinaEH ElinaEH commented Nov 22, 2024

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent setup of global state using Zustand! I just made some small comments about cleaning up the code, but apart from that - it looks super! 💃

src/App.jsx Outdated
Comment on lines 8 to 12
<div>
<Header />
<TodoForm />
<TodoList />
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

Comment on lines 7 to 15
<div>
<header className="header">
<h1 className="title">To-Do List</h1>
<h2 className="sub-title">Work smarter, Not harder</h2>
<div className="animation-container">
<Animation />
</div>
</header>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

Comment on lines 28 to 40
<form onSubmit={handleSubmit}>
<div className="input-container">
<label htmlFor="todoInput">New task:</label>
<input
id="todoInput"
type="text"
value={input}
onChange={handleInputChange}
placeholder="Write something here" className="textfield"
/>
<button className="add-task-button" type="submit">Add task</button>
</div>
</form>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you're using the form element as well as adding labels to your inputs ⭐

@@ -0,0 +1,42 @@
//Component for single task

import React from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to import React

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the hard work on the .jason (it was challenging because it was our first time on Zustand!). Congrats on solve, on my oppinion, the hardest part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants