TaskBuddy #33
Open
TaskBuddy #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and added a function and a button to remove tasks
HIPPIEKICK
requested changes
Nov 26, 2024
src/App.jsx
Outdated
Comment on lines
6
to
9
| <> | ||
| <Header/> | ||
| <TaskContainer/> | ||
| </> |
Comment on lines
1
to
24
| import styled from "styled-components" | ||
| import { TaskList } from "./TaskList" | ||
| import { TaskForm } from "./TasksForm" | ||
|
|
||
| const TaskWrapper = styled.div` | ||
| margin: 0 auto; | ||
| max-width: 80vw; | ||
| min-height: 50vw; | ||
| box-sizing: border-box; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: flex-start; | ||
| flex-direction: column; | ||
| margin-bottom: 3.125; | ||
| `; | ||
|
|
||
| export const TaskContainer = () => { | ||
| return( | ||
| <TaskWrapper> | ||
| <TaskForm/> | ||
| <TaskList/> | ||
| </TaskWrapper> | ||
| ) | ||
| }; |
There was a problem hiding this comment.
Consistency, are you using semicolons or not? ;)
src/components/tasks/TaskList.jsx
Outdated
| display: flex; | ||
| flex-direction: row; | ||
| align-items: center; | ||
| `; |
src/components/tasks/TaskList.jsx
Outdated
Comment on lines
109
to
128
| const Input = styled.input` | ||
| appearance: none; | ||
| min-width: 1.25rem; | ||
| max-width: 1.25rem; | ||
| height: 1.25rem; | ||
| border: 0.0625rem solid black; | ||
| cursor: pointer; | ||
| &:checked { | ||
| border: 0.125rem solid green; | ||
| position: relative; | ||
| } | ||
| &:checked::after { | ||
| content: '✓'; | ||
| color: green; | ||
| font-size: 1.875rem; | ||
| display: block; | ||
| text-align: center; | ||
| line-height: 0.5625rem; | ||
| } | ||
| `; |
src/components/tasks/TaskList.jsx
Outdated
Comment on lines
181
to
217
| const date = new Date(timestamp); | ||
| return date.toLocaleDateString("en-US", { | ||
| month: "numeric", | ||
| day: "numeric", | ||
| }); | ||
| }; | ||
|
|
||
| return ( | ||
| <TaskMap> | ||
| <TaskCount> | ||
| <p>Total tasks: {totalTaskCount()}</p> | ||
| <p>Completed tasks: {completedTaskCount()}</p> | ||
| </TaskCount> | ||
| {tasks.length === 0 ? ( | ||
| <NoTasks>You have no tasks yet. Let's add some!</NoTasks> | ||
| ) : ( | ||
| <ListWrapper> | ||
| <ListContainer> | ||
| {tasks.map((task) => ( | ||
| <List key={task.id}> | ||
| <Label> | ||
| <Input | ||
| type="checkbox" | ||
| checked={task.completed} | ||
| onChange={() => toggleTaskCompletion(task.id)} | ||
| /> | ||
| <TaskText $completed={task.completed.toString()}>{task.text}</TaskText> | ||
| <TaskDate>Added {formatDate(task.id)}</TaskDate> | ||
| </Label> | ||
| <RemoveButton onClick={() => removeTask(task.id)}><img src={bin} alt="Delete-Button" /></RemoveButton> | ||
| </List> | ||
| ))} | ||
| </ListContainer> | ||
| </ListWrapper> | ||
| )} | ||
| </TaskMap> | ||
| ); |
src/components/tasks/TasksForm.jsx
Outdated
| /> | ||
| <TaskButton type="submit">+ Add Task</TaskButton> | ||
| </Form> | ||
| ); |
Comment on lines
+11
to
+15
| tasks: [ | ||
| { id: 1, text: "Make to-do app", completed: false }, | ||
| { id: 2, text: "Clean kitchen", completed: true }, | ||
| { id: 3, text: "Walk the dog", completed: false }, | ||
| ], |
There was a problem hiding this comment.
Thanks for the feedback @HIPPIEKICK
HIPPIEKICK
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://fannys-taskbuddy.netlify.app