Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskly by Helene Westrin #43

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

HeleneWestrin
Copy link

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this to-do app is advanced ⭐ Your code is well-written in many ways but I think it can benefit from consistency and from cleaning it up a bit. E.g. using arrow functions all the way, naming all your components in PascalCase etc.

But the main thing I want to say is well done. You've put a lot of thought and effort into this app and its UI, and it shows.

PS. Even more impressed that you did this elaborate styling in Tailwind as well, kudos ⭐

@@ -0,0 +1,181 @@
import { create } from "zustand";
import { persist } from "zustand/middleware";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,181 @@
import { create } from "zustand";
import { persist } from "zustand/middleware";
import { nanoid } from "nanoid";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't heard of this, nice 👍

),
})),

editTask: (listId, taskId, editedTaskData) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants