-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jonas - Converting React-project to typescript #49
Open
Jonash189
wants to merge
15
commits into
Technigo:main
Choose a base branch
from
Jonash189:add-typescript
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate, FormEvent, and Zustand store functions.
… FC for the component. Fixed case sensitivity issue in App.jsx import by updating the path for MyToDoListPage to match the folder name. Restarted server to resolve issues.
… store structure. Typed Zustand functions (addTodo, removeTodo, toggleTodo) for improved safety and scalability.
…o TypeScript. Fixed 404 error caused by outdated file reference. Verified and ensured proper TypeScript setup for application entry point.
… and type safety.
…ed type annotations and ensured consistency across the project.
… handling and ensured consistent TypeScript annotations.
JennieDalgren
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
You have converted your code to TypeScript and implemented interfaces in a great way!
All approved
Good work with the commit messages too, easy to follow your process
⭐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL: https://jonas-typescript.netlify.app/
This PR introduces TypeScript to the project. Key changes include: