typescript-branch-project-16 #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 21, 2024 19:25
JennieDalgren
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Great job with this project! The typescript part is approved and all works well.
However, you are missing the count requirement from thhe todo app.
Your app should show a count of the tasks. Either all tasks or all uncompleted tasks (or both).
Fix that and both this project and last weeks project will be approved.
A minor thing is that the text color should change in dark mode. It's pretty hard to read the text in dark mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://typescript--mytodos-erika.netlify.app/
Collaborators