Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser tests in CI? #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Browser tests in CI? #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12bf9a0
Browser tests in CI?
TehShrike Jul 13, 2021
e0d0634
wait no run that job too
TehShrike Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,18 @@ jobs:
- checkout
- run: npm ci
- run: npm t
test_in_browser:
docker:
- image: circleci/node:16
steps:
- checkout
- run: sudo apt-get install xvfb
- run: npm ci
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to run npm run build here first? I notice in the one I made that it runs npm run test which has build as a side effect.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The browser script runs it too... https://github.com/TehShrike/abstract-state-router/blob/master/package.json#L9 ...I'm not sure what's going wrong :-x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got the browser scripts in a different job. My understanding is that assets weren't available across jobs unless you specified it or something?

- run: xvfb-run --auto-servernum npm run test:browser

workflows:
version: 2
test_and_build:
jobs:
- test_and_build
- test_in_browser