-
Notifications
You must be signed in to change notification settings - Fork 15
Add new workflow to bump version and create Github Release #36
base: master
Are you sure you want to change the base?
Conversation
author_email: [email protected] | ||
author_name: tuentisre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be considered as a secret to avoid spam?
as this is a public repo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably, i think security advisor will raise a warning with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the idea behind this workflow is to manually set the version. Shouldnt we have the version autoamtically managed ? Commit it in a version file in the repo and just bump it (semver or with other methods)
The version is already in the repository in the metadata.json file. That file is the one used by the pdk tool to build the artifact and use the version from there. If we create another file for version, it is going to be duplicated. |
ok then, let use that file to do an automated versioning instead of requiring the version to be an input of the workflow, that way we can autoamtically trigger a release on other events , such as PR merged |
cool workflow! FMPOV (agreed with Oscar) bumping version automatically (getting current version from json file) could be more useful rather than set it as an input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe makes more sense do it next time
Add a new workflow that is intended to be run once all branches for a release are already merged in the main branch.
This workflow is going to:
In a future step, it could be set here the step to publish the tgz into puppet forge.
Github actions used: