Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Add new workflow to bump version and create Github Release #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jan 12, 2022

Add a new workflow that is intended to be run once all branches for a release are already merged in the main branch.

This workflow is going to:

  • Set the right version in metadata.json
  • Create a Github Release with the corresponding release notes (auto-generated).

In a future step, it could be set here the step to publish the tgz into puppet forge.

Github actions used:

@mrodm mrodm requested a review from oscarsj as a code owner January 12, 2022 17:44
Comment on lines +38 to +39
author_email: [email protected]
author_name: tuentisre
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be considered as a secret to avoid spam?
as this is a public repo...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, i think security advisor will raise a warning with this

@mrodm mrodm requested a review from Yermanaco January 13, 2022 09:49
Copy link
Contributor

@oscarsj oscarsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the idea behind this workflow is to manually set the version. Shouldnt we have the version autoamtically managed ? Commit it in a version file in the repo and just bump it (semver or with other methods)

@mrodm
Copy link
Contributor Author

mrodm commented Jan 13, 2022

I see the idea behind this workflow is to manually set the version. Shouldnt we have the version autoamtically managed ? Commit it in a version file in the repo and just bump it (semver or with other methods)

The version is already in the repository in the metadata.json file. That file is the one used by the pdk tool to build the artifact and use the version from there. If we create another file for version, it is going to be duplicated.

@oscarsj
Copy link
Contributor

oscarsj commented Jan 13, 2022

I see the idea behind this workflow is to manually set the version. Shouldnt we have the version autoamtically managed ? Commit it in a version file in the repo and just bump it (semver or with other methods)

The version is already in the repository in the metadata.json file. That file is the one used by the pdk tool to build the artifact and use the version from there. If we create another file for version, it is going to be duplicated.

ok then, let use that file to do an automated versioning instead of requiring the version to be an input of the workflow, that way we can autoamtically trigger a release on other events , such as PR merged

@Yermanaco
Copy link

Yermanaco commented Jan 13, 2022

cool workflow! FMPOV (agreed with Oscar) bumping version automatically (getting current version from json file) could be more useful rather than set it as an input.

Copy link

@Yermanaco Yermanaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe makes more sense do it next time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants