Overhaul qemu disks merge #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows for the user to manually provide the current config or let the library provide the config
…ring]interface{}}`
disks getting updated when nothing changes, adds the current state to the pending state.
before it was defined of each disk, but it is the same for all linked disk. thats why it's moved to `ConfigQemu`. when the vm has no linked disks `LinkedVmId` becomes `0`
mabeett
added a commit
to mabeett/packer-plugin-proxmox
that referenced
this pull request
May 29, 2023
The latest main for the proxmox-api-go project includes RNG device creation. Return value for proxmox.ConfigQemu.CreateQemuEfiParams() have changed ( Telmate/proxmox-api-go#255 )
lbajolet-hashicorp
pushed a commit
to hashicorp/packer-plugin-proxmox
that referenced
this pull request
Jul 12, 2023
The latest main for the proxmox-api-go project includes RNG device creation. Return value for proxmox.ConfigQemu.CreateQemuEfiParams() have changed ( Telmate/proxmox-api-go#255 )
Heads up: This was a fatal blow to the downstream terraform provider. In API terms, “deprecated” means discouraged for use and likely to be removed, while “obsolete” means already removed or replaced. Perhaps this should be removed from QemuConfig or at least have its comment updated? 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new implementation of the disk structure discussed in #187 and deprecates the old implementation.
Code reworked:
ConfigQemudata structure to its own function to improve test-ability.ConfigQemuto its own function to improve test-ability.nil.ConfigQemufunc NewConfigQemuFromApi(will no longer return the deprecated parts oftype ConfigQemuFeatures added:
func (newConfig ConfigQemu) setAdvanced).func (storages QemuStorages) Validate()func MoveQemuDiskto be a full implementation for disk migration, storage/disk-type change.type ConfigQemu.Isoto keep the spirit of the old implementation. This feature feels out of place in this code and should be delegated to implementations like the Terraform provider.Features deprecated:
func (config ConfigQemu) CreateVmfunc (config ConfigQemu) UpdateConfigfunc (c *Client) MoveQemuDisktype ConfigQemu.QemuDiskstype ConfigQemu.QemuIsoAll the deprecated functions still work and don't make use of the new disk implementation (bugs included).
Reasoning for moving the CRUD logic to this library:
Currently I am working on a Terraform implementation.