Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-implement the way qemu disks are handled #889

Closed
wants to merge 2 commits into from

Conversation

hestiahacker
Copy link
Contributor

These changes were pulled from Tinyblargon's branch which was out of sync with the Telmate master branch. I merely dealt with the merge conflicts so we could re-submit a new merge request that can be applied cleanly.

The original merge request is at #794

I have also tested this and verified that these changes fix #887

These changes were pulled from Tinyblargon's branch which was out of sync
with the Telmate master branch. I merely dealt with the merge conflicts so
we could re-submit a new merge request that can be applied cleanly.

Ref: Telmate#794
@Tinyblargon
Copy link
Collaborator

@hestiahacker First of thank you for re-basing this.

@mleone87
There are a few bugs with my original code #794, which I've been patching over the last week.
Once this PR gets merged I'll be able to apply my patches.
These patches would consist of:

  • fixed panics in weird edge cases.
  • added back features that where supported by the old disk schema wwn property for example.
  • improved validator logic.
  • diff incorrectly, forgot to read some properties into the data structure.

Some of the bugs where in the upstream proxmox Library Telmate/proxmox-api-go#292

@MaartendeKruijf
Copy link
Contributor

@Tinyblargon could you rebase onto this commit and apply your patches that would be much cleaner as to separate PR's?

@hestiahacker
Copy link
Contributor Author

This MR has been superseded by #892

As best I can tell, MR 892 has all these changes (and more) so I'm closing this MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate disks created
3 participants