Skip to content

Commit

Permalink
Fix/front end fixes 25082024 (#598)
Browse files Browse the repository at this point in the history
* Fix buttons in discover card

* Add interns to bios section

* Make content collapsible

* Add visual element for collapsible behavior

* Move save btn to top left corner

* Address security vulnerability

* Update current members bios

* Move past interns to its section
  • Loading branch information
aliciapaz authored Aug 27, 2024
1 parent 990075a commit b858877
Show file tree
Hide file tree
Showing 8 changed files with 267 additions and 186 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ GEM
responders (3.0.1)
actionpack (>= 5.0)
railties (>= 5.0)
rexml (3.3.4)
rexml (3.3.6)
strscan
rgeo (2.3.1)
rgeo-activerecord (7.0.1)
Expand Down
Binary file added app/assets/images/charlotte.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/jenna.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/saniya.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/components/discover_nonprofit_card/component.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ article class="overflow-hidden text-xs font-medium bg-white rounded shadow-md"
// Donate/Volunteer buttons
section class="relative w-full"
h3 class="sr-only" altruistic menu
= render "locations/donate_volunteer_buttons", location: @location, container_styles: "flex gap-x-4 w-full pt-5 pb-3 border-t border-gray-8 text-base", find_help_link: location_path(@location)
= render "locations/donate_volunteer_buttons", location: @location, container_styles: "flex flex-col gap-4 w-full pt-5 pb-3 border-t border-gray-8 text-base", find_help_link: location_path(@location)
// Actions menu
section class="pt-6 pb-11 border-t border-gray-8"
h3 class="w-0 h-0 opacity-0" actions menu
Expand Down
5 changes: 3 additions & 2 deletions app/components/location_infowindow/component.html.slim
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
span class="absolute top-4 left-4 ml-1"
= render SaveButton::Component.new(user: @current_user, location: @location, simplified: true)

div.flex.items-center.justify-between.w-full
// Logo
div.flex-grow.flex.justify-center
Expand All @@ -9,8 +12,6 @@ div class="flex flex-row gap-1 justify-between items-start"
= link_to @location.name, location_path(@location), target:"_blank", class: "text-small font-bold text-gray-2"
- if @location.organization.verified?
= render partial: "shared/popover", locals: {position: "right-0", copy: "Information verified by nonprofit.", wrapper_icon: "verified_nonprofit_check.svg"}
span class="flex ml-1"
= render SaveButton::Component.new(user: @current_user, location: @location, simplified: true)

// Address, website, phone, and availability
- if @location.public_address?
Expand Down
200 changes: 200 additions & 0 deletions app/views/about_us/_interns.html.slim

Large diffs are not rendered by default.

244 changes: 62 additions & 182 deletions app/views/about_us/show.html.slim

Large diffs are not rendered by default.

0 comments on commit b858877

Please sign in to comment.