Fix/Many controls in search empty state not working #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosueMagnus12
commented
Jan 25, 2024
| p class="text-xl font-bold text-center " | ||
| | We couldn't find any nonprofits that matched your search. | ||
| p class="max-w-xs px-4 text-base text-center" | ||
| | Try searching for another keyword or editing your filters. | ||
| button class="text-sm font-bold text-blue-medium" type="submit" data-action="click->search#clearAll" | ||
| button class="text-sm font-bold text-blue-medium" type="submit" data-action="click->search#clearKeywordInput click->search#clearCheckedPills click->search#clearAll" |
There was a problem hiding this comment.
Not the most elegant approach, but this is the quickest solution. Let's add the refactor of all of this as tech debt.
JosueMagnus12
changed the title
aliciapaz
reviewed
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The "create alert" and "clear filters" buttons on the search page (empty. state) were not working correctly.
What changed
How to test it
http://localhost:5000/searchReferences
ClickUp ticket | Alerts
ClickUp ticket | Keyword