Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Add Donate and Volunteer Buttons to Discover Page Cards #512

Merged
merged 10 commits into from
Feb 9, 2024
Merged

Feature/Add Donate and Volunteer Buttons to Discover Page Cards #512

merged 10 commits into from
Feb 9, 2024

Conversation

JosueMagnus12
Copy link
Collaborator

@JosueMagnus12 JosueMagnus12 commented Feb 9, 2024 •
edited
Loading

What changed

  • Added donate_volunteer_buttons partial to discover_nonprofit_card component.
  • Improved image accessibility inside buttons

How to test it

  1. Go to admin panel and create a new Org Admin
  2. Go back to your account on the "My nonprofit pages"
  3. Edit the nonprofit by adding donate and volunteer buttons
  4. Go to the Discover page and search that nonprofit

References

ClickUp ticket

Demo

Screenshot 2024-02-09 at 11 13 39 a m (2)

AlanSoto31
AlanSoto31 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@AlanSoto31 AlanSoto31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JosueMagnus12 JosueMagnus12 merged commit f9cd6e1 into main Feb 9, 2024
2 checks passed
@JosueMagnus12 JosueMagnus12 deleted the feature/donate-volunteer-buttons-discover-page branch February 9, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanSoto31 AlanSoto31 AlanSoto31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosueMagnus12 @AlanSoto31