Feature/nonprofit form error message #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sable turbo in form, and improve form markup.
JosueMagnus12
commented
Feb 13, 2024
Comment on lines
+1
to
+11
| import { Controller } from '@hotwired/stimulus' | ||
|
|
||
| export default class extends Controller { | ||
| static values = { targetUrls: Array } | ||
|
|
||
| disableTurboForTargetUrls(event) { | ||
| if (this.targetUrlsValue.includes(event.detail.url)) { | ||
| event.preventDefault(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Even if we disable turbo in the message forms with data-turbo="false", the RECaptcha is still failing. Adding the data-turbo-track="reload" meta tag doesn't help either, because it wipes the form error messages.
The only viable solution I found is to disable turbo before the browser issues a new request to fetch these forms. This is great because it can work across the entire app and we don't have to add data-turbo="false" to every link_to that links to these forms.
JosueMagnus12
commented
Feb 13, 2024
Comment on lines
+12
to
+16
|
|
||
| # recaptcha gem doesn't work well with Turbo | ||
| def turbo_disabled_urls | ||
| [new_nonprofit_request_url, new_contact_message_url] | ||
| end |
There was a problem hiding this comment.
Just add the urls for which you want to disable Turbo.
AlanSoto31
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Users were having problems sending a message on the "add a nonprofit" when submitting the form. Basically no error messages were displayed and the field were wiped.
What changed
How to test it
References
ClickUp ticket