Fix guard in searches controller #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliciapaz
added a commit
that referenced
this pull request
Mar 27, 2024
aliciapaz
added a commit
that referenced
this pull request
Apr 17, 2024
* Remove workaround after devise upgrade * Share location and display it in navbar * Navbar dropdown * Style and fix navbar dropdown behavior * Create random locations within 1000 Us cities * Search filters * Use hidden inputs in search form * Update form with chosen city * Update city in both navbar and search pills * Add coordinates in search form * Use Locationable to set current location * Fix random coordinates for cities seed data * Fix random coordinates for cities seed data * Fix guard in searches controller (#538) * Fix/keyword search not working 03262024 (#539) * Fix guard in searches controller * Fix keyword search and tab in navbar * Rename reference to dropdown controller * Ignore asdf version file * Make geosearch * Extract cookie logic * Fix search tab behavior * Add dropdown in navbar * Pass locations to nav bar and search bar components * Style search bar * Trigger form submission on location change * Move navbar dropdown to right corner * Fix seeds * Fix city dropdown responsiveness * Fix searchbar on mobile * Remove geolocation from places controller * Add stimulus target guard to prevent error outside form scope * Filter discover results by location * Handle search failed scenario * Update banner * Remove custom responders to address devise deprecation warning * Fix discover search by location * Refresh discover results upon location change * Retrieve international and nationwide orgs in geolocation search * Move navbar buttons to the right * Add search all option * Create custom routes for nashville and atlantic city * Fix search query * Avoid duplicated function calls * Move clear button in search bar * Fix navbar cluttering on mid size screens * Add dropdown in mobile navbar * Fix dropdown toggle * Refactor get cookie method * Update breakpoints for navbar --------- Co-authored-by: Alan Soto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Keyword search was not working from the home page
What changed
Change guard in searches controller
How to test it
References
ClickUp ticket