-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature | Geolocation expansion atlantic #543
Merged
Merged
Changes from 50 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
51341cd
Remove workaround after devise upgrade
aliciapaz d072036
Share location and display it in navbar
aliciapaz fd30f95
Navbar dropdown
aliciapaz 529740e
Style and fix navbar dropdown behavior
aliciapaz 58ae33f
Create random locations within 1000 Us cities
AlanSoto31 57e6ef1
Search filters
aliciapaz bbd8b15
Use hidden inputs in search form
aliciapaz 7097df0
Update form with chosen city
aliciapaz 81889dd
Update city in both navbar and search pills
aliciapaz c3f6853
Add coordinates in search form
aliciapaz 5e57df1
Use Locationable to set current location
aliciapaz 50f16f1
Fix random coordinates for cities seed data
aliciapaz 71371dc
Fix random coordinates for cities seed data
aliciapaz 2d817ae
Fix guard in searches controller (#538)
aliciapaz 5dbe0a4
Fix/keyword search not working 03262024 (#539)
aliciapaz 84366ed
Rename reference to dropdown controller
aliciapaz e9bf6a7
Ignore asdf version file
aliciapaz d7d32ea
Make geosearch
aliciapaz 03fa37f
Extract cookie logic
aliciapaz ef908cf
Fix search tab behavior
aliciapaz f87aa5b
Add dropdown in navbar
aliciapaz de1408c
Pass locations to nav bar and search bar components
aliciapaz 65c8e31
ed22170
Style search bar
aliciapaz 44e2867
Merge branch 'main' into feature/geolocation-expansion-atlantic
aliciapaz f385e48
Trigger form submission on location change
aliciapaz 62b8ed4
Move navbar dropdown to right corner
aliciapaz b68ffbc
Fix seeds
aliciapaz 7e65f15
Merge branch 'main' into feature/geolocation-expansion-atlantic
aliciapaz ceaddd4
Fix city dropdown responsiveness
aliciapaz be85677
Merge branch 'main' into feature/geolocation-expansion-atlantic
aliciapaz e2f8669
Fix searchbar on mobile
aliciapaz d007b8f
Remove geolocation from places controller
aliciapaz a3c3709
Add stimulus target guard to prevent error outside form scope
aliciapaz 7bd701e
Filter discover results by location
aliciapaz 490705b
Handle search failed scenario
aliciapaz e39fac1
Update banner
aliciapaz b306cf1
Merge branch 'main' into feature/geolocation-expansion-atlantic
aliciapaz 21f67bc
Remove custom responders to address devise deprecation warning
aliciapaz 46c07b4
Fix discover search by location
aliciapaz 133a340
Refresh discover results upon location change
aliciapaz fa1807d
Retrieve international and nationwide orgs in geolocation search
aliciapaz 74b34df
Move navbar buttons to the right
aliciapaz 2cdad17
Add search all option
aliciapaz 268ec5b
Create custom routes for nashville and atlantic city
aliciapaz c384a36
Fix search query
aliciapaz c1f4691
Avoid duplicated function calls
aliciapaz 307b3d1
Move clear button in search bar
aliciapaz e8a4de9
Fix navbar cluttering on mid size screens
aliciapaz 1199d02
Add dropdown in mobile navbar
aliciapaz 8d3f6ef
Fix dropdown toggle
aliciapaz 123b6e6
Refactor get cookie method
aliciapaz 90ffa89
Update breakpoints for navbar
aliciapaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,3 +44,6 @@ yarn-debug.log* | |
database_consistency* | ||
|
||
.DS_Store | ||
|
||
# Ignore asdf version files | ||
/.tool-versions |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,11 @@ | ||
# frozen_string_literal: true | ||
|
||
# navbar view component | ||
# rubocop:disable Style/ClassAndModuleChildren | ||
# rubocop:disable Lint/MissingSuper | ||
class Navbar::Component < ApplicationViewComponent | ||
def initialize(signed_in:) | ||
def initialize(signed_in:, current_location:, locations: @locations) | ||
@current_location = current_location | ||
@signed_in = signed_in | ||
@locations = locations | ||
end | ||
|
||
def non_sticky_paths | ||
request.env["PATH_INFO"] == "/searches" || request.env["PATH_INFO"] == "/my_account" | ||
end | ||
end | ||
|
||
# rubocop:enable Style/ClassAndModuleChildren | ||
# rubocop:enable Lint/MissingSuper |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The navbar looks way better, thank you! We can extend these breakpoints inside
&--mobile
and&--desktop
rules a little bit more (870px
the average size of a smartphone screen in horizontal) to enhance the layout even more:iPad mini size:
870px screens: