Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geolocation expansion fixes #550

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Conversation

aliciapaz
Copy link
Collaborator

@aliciapaz aliciapaz commented Apr 18, 2024

Context

Feedback from Steph:

  • 1.1 Can we make it so the location is all on one line (see attached) in the nav bar when you select "Search near me"? I'm fine with moving over the global location in the nav bar to accommodate.
  • 1.2 When you select "Search all" then enter a keyword like "food" (only 2 nonprofits show up) but then you click the x next to the keyword to reset the search, it only shows 5 nonprofits. If you leave then come back to the search platform, it shows all 50 nonprofits.
  • 1.3 There is an issue with the Advanced Filters. When I select a cause, the little notification with the x doesn't appear in the far left to indicate a filter has been used.
  • 1.4 On mobile, '"Search all" is only showing 5 results.
  • 1.5 On mobile from the homepage, you cannot select "Search near me".
  • 1.6 On mobile, can we center our logo in the nav bar?
  • 1.7 Can we change the following language on the Discover Page?
    "Use our browse by cause feature to find nonprofits serving the community in Nashville or Atlantic City. Select a cause below to learn more about organizations providing critical services within your chosen cause category. Scroll through listings to discover nonprofits meeting your needs."

Additional notes on the fixes:

ClickUp ticket

@aliciapaz aliciapaz self-assigned this Apr 18, 2024
@aliciapaz aliciapaz changed the title Fix location with in navbar Geolocation expansion fixes Apr 18, 2024
@aliciapaz aliciapaz marked this pull request as ready for review April 18, 2024 17:51
Copy link
Collaborator

@JosueMagnus12 JosueMagnus12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look fine 👍

Note: I noticed an under performance on the search page applying long distance filters (more pins and locations to process I guess?).

I don't see this as an urgency right now because there are just hundreds of non-profits registered in prod. However, performance can be a major issue when that number increases.

ddd.mov

@aliciapaz aliciapaz merged commit 1496191 into main Apr 18, 2024
6 checks passed
@aliciapaz aliciapaz deleted the fix/geolocation-expansion-04182024 branch April 18, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants