TKSS-1044: Provide one-shot native crypto implementations #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshajiang
force-pushed
the
TKSS-1044
branch
from
9331d66 to
cac61b6
Compare
johnshajiang
force-pushed
the
TKSS-1044
branch
from
cac61b6 to
0e11a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the native crypto implementation contains multiple steps, including creating native context, doing update operation, doing final operation and free the native context finally.
The native resource is freeing via GC.
This way may consume much more GC time when many native objects are managed by the reference queue.
Supply an additional native crypto provider for short data, and all the above crypto operations are done in a single function.
So, it is unnecessary to manage the native resource via GC.
This PR will resolves #1044.