Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that the imageScaleModes is not effective with editable image #2683

Closed
wants to merge 2 commits into from

Conversation

CodeJhF
Copy link
Collaborator

@CodeJhF CodeJhF commented Feb 18, 2025

Fix the issue that the imageScaleModes is not effective with editable image

@CodeJhF CodeJhF closed this Feb 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.25%. Comparing base (594fec6) to head (16bd121).

Files with missing lines Patch % Lines
src/rendering/editing/ImageReplacement.cpp 42.10% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
- Coverage   77.30%   77.25%   -0.06%     
==========================================
  Files         425      425              
  Lines       22461    22478      +17     
  Branches     6356     6367      +11     
==========================================
+ Hits        17364    17365       +1     
- Misses       3805     3820      +15     
- Partials     1292     1293       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants