Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pnpm workspace and pnpm manage limit #3404

Merged
merged 25 commits into from
Mar 10, 2025
Merged

Conversation

HaixingOoO
Copy link
Collaborator

@HaixingOoO HaixingOoO commented Mar 2, 2025

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • chore: add pnpm workspace and pnpm manage limit

  • chore: run site and build productions within packages/tdesign-react

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Mar 2, 2025

失败

@liweijie0812 liweijie0812 requested a review from Copilot March 4, 2025 15:56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@liweijie0812 liweijie0812 requested a review from Copilot March 5, 2025 16:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR introduces support for a pnpm workspace setup along with enhancements to workflow management for building, testing, and previewing deployments. Key changes include the addition of new GitHub Actions jobs for preview deployments, updates to the pull-request workflow to integrate pnpm and email validations, and modifications in example files to update component import paths.

Reviewed Changes

File Description
.github/workflows/preview-publish.yml Added new jobs for handling successful and failed preview deployments via Surge.
.github/workflows/pull-request.yml Introduced new jobs for email verification, testing, site generation, and build processes using pnpm.
packages/components//_example/.tsx Updated import paths from 'tdesign-react' to '@tdesign/components' for consistency.

Copilot reviewed 679 out of 679 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/preview-publish.yml:26

  • Consider adding a check to verify that pr-id.txt exists before reading it. This can help avoid potential runtime errors if the artifact is not available.
run: echo "id=$(<pr-id.txt)" >> $GITHUB_OUTPUT

.github/workflows/pull-request.yml:24

  • [nitpick] Consider providing a clearer, more detailed error message that guides the user on how to resolve the email validation issue.
echo "默认邮箱 $log_emails 校验非法,可以去 https://github.com/settings/emails 更改"
@uyarn uyarn closed this Mar 9, 2025
@uyarn uyarn reopened this Mar 9, 2025
@uyarn uyarn merged commit bb535b4 into develop Mar 10, 2025
10 checks passed
@uyarn uyarn deleted the chore/pnpm/manage-limit branch March 10, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants