feat: project-manager提供项目活跃度接口 #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LidolLxf
force-pushed
the
feat_project_activity
branch
from
7fb3154 to
027856a
Compare
adevjoe
suggested changes
Dec 5, 2024
| } | ||
|
|
||
| // 没有集群则返回不活跃 | ||
| if len(clusters) == 0 { |
|
|
||
| // 没有共享集群命名空间则返回不活跃 | ||
| for _, v := range clusters { | ||
| if v.IsShared { |
AlkaidChan
reviewed
Dec 5, 2024
|
|
||
| p, err := ga.model.GetProject(ctx, req.ProjectIDOrCode) | ||
| // 未开启容器服务，直接返回不活跃 | ||
| if err == drivers.ErrTableRecordNotFound { |
There was a problem hiding this comment.
项目不存在直接报错就行吧，本身就是请求参数错误
| } | ||
|
|
||
| // 未开启容器服务，直接返回不活跃 | ||
| if p.Kind != "k8s" { |
There was a problem hiding this comment.
我们内部还有 mesos 的项目，这里直接判断这个字段是否为空就好了，为空就是未开启，
| }]; | ||
| ProjectActiveData data = 3[(grpc.gateway.protoc_gen_swagger.options.openapiv2_field) = { | ||
| title: "data", | ||
| description: "返回可用业务列表" |
LidolLxf
force-pushed
the
feat_project_activity
branch
from
acd667a to
ee201b3
Compare
adevjoe
approved these changes
Dec 5, 2024
LidolLxf
force-pushed
the
feat_project_activity
branch
from
ee201b3 to
62af3bb
Compare
ifooth
approved these changes
Dec 5, 2024
evanlixin
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: project-manager提供项目活跃度接口