feat: bcs-monitor rest 泛型优化 #3681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LidolLxf
force-pushed
the
feat_monitor_rest
branch
4 times, most recently
from
f881b51 to
e7fee4d
Compare
ifooth
reviewed
Feb 25, 2025
| @@ -28,101 +31,133 @@ const ( | |||
| // @Tags Metrics | |||
| // @Success 200 {string} string | |||
| // @Router /overview [get] | |||
| func GetClusterOverview(c *rest.Context) (interface{}, error) { | |||
| handler, err := query.HandlerFactory(c.Request.Context(), c.ClusterId) | |||
| func GetClusterOverview(c context.Context, req query.GetClusterOverviewReq) (query.ClusterOverviewMetric, error) { | |||
There was a problem hiding this comment.
- 入参，出差应该都是用指针类型
- 默认添加Validate做参数校验
- 下同
|
|
||
| // GetLogRuleReq get log rule request | ||
| type GetLogRuleReq struct { | ||
| ProjectId string `json:"-" in:"path=projectId;required"` |
| if err != nil { | ||
| return nil, err | ||
| return promclient.ResultData{}, err |
| } | ||
|
|
||
| // ClusterCPURequestUsage 集群 CPU 装箱率 | ||
| // @Summary 集群 CPU 装箱率 | ||
| // @Tags Metrics | ||
| // @Success 200 {string} string | ||
| // @Router /cpu_request_usage [get] | ||
| func ClusterCPURequestUsage(c *rest.Context) (interface{}, error) { | ||
| handler, err := query.HandlerFactory(c.Request.Context(), c.ClusterId) | ||
| func ClusterCPURequestUsage(c context.Context, uQuery query.UsageQuery) (promclient.ResultData, error) { |
There was a problem hiding this comment.
这里函数签名统一使用req吧(req *query.UsageQuery)，下同
|
|
||
| route.Get("/namespaces/{namespace}/pods/{pod}/containers", rest.Handler(pod.GetPodContainers)) | ||
| route.Get("/namespaces/{namespace}/pods/{pod}/logs", rest.Handler(pod.GetPodLog)) | ||
| route.Get("/namespaces/{namespace}/pods/{pod}/logs/download", rest.StreamHandler(pod.DownloadPodLog)) |
There was a problem hiding this comment.
这个命名先和现在项目统一下， 直接使用Handle/Stream 都是动词，主要是简洁点
LidolLxf
force-pushed
the
feat_monitor_rest
branch
from
9b2918a to
eca9639
Compare
LidolLxf
force-pushed
the
feat_monitor_rest
branch
from
980aad5 to
ca9ec12
Compare
LidolLxf
force-pushed
the
feat_monitor_rest
branch
from
ca9ec12 to
142f7ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: bcs-monitor rest 泛型优化