fix:修复离职用户SaaS部分表数据未清理 #2843
Open
fix:修复离职用户SaaS部分表数据未清理 #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nannan00
reviewed
Jan 2, 2025
|
|
||
| SubjectToDelete.objects.bulk_create( | ||
| [SubjectToDelete(subject_id=subject_id, | ||
| subject_type=SubjectType.USER.value) for subject_id in new_subject_ids]) |
There was a problem hiding this comment.
- 遗留数据不应该与正常逻辑耦合
- 遗留数据清理，可以使用 Django Command 方式提供（且可以直接清理遗留的表，而不需要重新添加到待删除的数subject里）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
变更点(Changes)
相关issues (Which issues this PR fixes)
备注(Special notes)