Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: 新增或更新主机信息异常 (closed #1845) #1847

Merged

Conversation

CohleRustW
Copy link
Collaborator

@CohleRustW CohleRustW commented Oct 10, 2023

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@CohleRustW CohleRustW added the pr/reviewable 可被 review 的 PR label Oct 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1847 (30a4759) into v2.4.2-dev (9b536c2) will decrease coverage by 0.01%.
Report is 1 commits behind head on v2.4.2-dev.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           v2.4.2-dev    #1847      +/-   ##
==============================================
- Coverage       74.33%   74.33%   -0.01%     
==============================================
  Files             398      398              
  Lines           27134    27134              
==============================================
- Hits            20171    20170       -1     
- Misses           6963     6964       +1     
Files Coverage Δ
...nents/collections/agent_new/add_or_update_hosts.py 90.66% <ø> (ø)

... and 1 file with indirect coverage changes

@CohleRustW
Copy link
Collaborator Author

只有通过订阅创建的安装任务才会有这个问题,通过 job 接口会被拦截

Copy link
Member

@ZhuoZhuoCrayon ZhuoZhuoCrayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhuoZhuoCrayon ZhuoZhuoCrayon merged commit a7a089f into TencentBlueKing:v2.4.2-dev Oct 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/reviewable 可被 review 的 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants