Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Agent 配置重载功能优化 (closed #1769) #1861

Closed

Conversation

wyyalt
Copy link
Collaborator

@wyyalt wyyalt commented Oct 16, 2023

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #1861 (8b99473) into v2.4.2-dev (9997f4f) will increase coverage by 0.00%.
The diff coverage is 92.30%.

@@             Coverage Diff             @@
##           v2.4.2-dev    #1861   +/-   ##
===========================================
  Coverage       74.38%   74.39%           
===========================================
  Files             398      398           
  Lines           27134    27144   +10     
===========================================
+ Hits            20184    20193    +9     
- Misses           6950     6951    +1     
Files Coverage Δ
...ollections/agent_new/render_and_push_gse_config.py 100.00% <100.00%> (ø)
apps/backend/constants.py 98.00% <100.00%> (+0.12%) ⬆️
...ackend/subscription/steps/agent_adapter/adapter.py 91.78% <80.00%> (-0.87%) ⬇️

@wyyalt wyyalt added the pr/reviewable 可被 review 的 PR label Oct 18, 2023
@wyyalt wyyalt force-pushed the _v2.4.x/dev_issue#1769 branch from 842cade to 8b99473 Compare October 18, 2023 08:49
Copy link
Member

@ZhuoZhuoCrayon ZhuoZhuoCrayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充单元测试,验证下配置生成的内容、数量没问题。

单元测试参考:apps/backend/tests/components/collections/agent_new/test_push_agent_pkg_to_proxy.py

根据调用记录判断

企业微信截图_87e731de-c5b4-4d7d-85aa-9ac08ee00872

ZhuoZhuoCrayon and others added 26 commits October 24, 2023 09:21
…g#1801)

* feature:  提供同步主机时接入点选择策略 (closed TencentBlueKing#1790)

* feature:  提供同步主机时接入点选择策略 (closed TencentBlueKing#1790)
@wyyalt wyyalt force-pushed the _v2.4.x/dev_issue#1769 branch from 8b99473 to 1e5091c Compare October 25, 2023 11:07
@wyyalt wyyalt force-pushed the _v2.4.x/dev_issue#1769 branch from 1e5091c to cc843c6 Compare October 25, 2023 11:08
@wyyalt wyyalt closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/reviewable 可被 review 的 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants