Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: windows安装脚本下载包异常修复 (closed #1873) #1874

Merged

Conversation

wyyalt
Copy link
Collaborator

@wyyalt wyyalt commented Oct 19, 2023

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #1874 (1e1705d) into v2.4.2-dev (9997f4f) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           v2.4.2-dev    #1874   +/-   ##
===========================================
  Coverage       74.38%   74.38%           
===========================================
  Files             398      398           
  Lines           27134    27134           
===========================================
  Hits            20184    20184           
  Misses           6950     6950           

@wyyalt wyyalt force-pushed the _v2.4.x/dev_issue#1873 branch from 5257b1f to 1e1705d Compare October 23, 2023 04:11
@wyyalt wyyalt added the pr/reviewable 可被 review 的 PR label Oct 23, 2023
Copy link
Member

@ZhuoZhuoCrayon ZhuoZhuoCrayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhuoZhuoCrayon ZhuoZhuoCrayon merged commit c052348 into TencentBlueKing:v2.4.2-dev Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/reviewable 可被 review 的 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants