feat: added operation audit for idp and user #1974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nannan00
reviewed
Nov 8, 2024
| "status": idp.status, | ||
| "plugin_config": idp.plugin_config, | ||
| "data_source_match_rules": idp.data_source_match_rules, | ||
| }, |
| @@ -226,6 +251,16 @@ def put(self, request, *args, **kwargs): | |||
| ) | |||
| idp.set_plugin_cfg(data["plugin_config"]) | |||
|
|
|||
| # 审计记录 | |||
| add_audit_record( | |||
| operator=idp.updater, | |||
There was a problem hiding this comment.
Nit: 建议提前 current_user 变量，避免依赖使用 B.x = u , C.y = B.x, D.z = C.y
| "status": idp.status, | ||
| "plugin_config": idp.plugin_config, | ||
| "data_source_match_rules": idp.data_source_match_rules, | ||
| }, |
| extras={ | ||
| "departments": list(data_source_dept_ids), | ||
| # 记录 name 便于前端展示 | ||
| "name": user.data_source_user.username, |
There was a problem hiding this comment.
- 存在二义性字段建议明确名称， departments => data_source_department_ids
- name -> username ，不建议偷偷修改变量 Key，引入排查和理解成本
| tenant_id=cur_tenant_id, | ||
| id__in=data["user_ids"], | ||
| ).select_related("data_source_user") | ||
| ] |
There was a problem hiding this comment.
这样查询是将之前已经添加都查询出来了，而不是本次添加的
| user_department_relations = DataSourceDepartmentUserRelation.objects.filter( | ||
| user_id__in=data_source_user_ids | ||
| ).values("department_id", "user_id") | ||
| user_departments_map = defaultdict(list) |
There was a problem hiding this comment.
user_departments_map 就近原则
| tenant_id=cur_tenant_id, | ||
| id__in=data["user_ids"], | ||
| ).select_related("data_source_user") | ||
| ] |
| tenant_id=cur_tenant_id, | ||
| id__in=data["user_ids"], | ||
| ).select_related("data_source_user") | ||
| ] |
| "extras": data_source_user.extras, | ||
| "departments": list(department_ids), | ||
| "leaders": list(leader_ids), | ||
| "account_expired_at": tenant_user.account_expired_at.strftime("%Y-%m-%d %H:%M:%S"), |
There was a problem hiding this comment.
最好下沉到 tenant_user.account_expored_at_display() 对象的方法；
wklken
reviewed
Nov 8, 2024
| operation=OperationEnum.MODIFY_IDP, | ||
| object_type=ObjectTypeEnum.IDP, | ||
| object_id=idp.id, | ||
| extras={"data_before": data_before}, |
wklken
reviewed
Nov 8, 2024
| @@ -41,7 +41,6 @@ class OperationEnum(str, StructuredEnum): | |||
| # 认证源 | |||
| CREATE_IDP = EnumField("create_idp", label=_("创建认证源")) | |||
| MODIFY_IDP = EnumField("modify_idp", label=_("修改认证源")) | |||
| MODIFY_IDP_STATUS = EnumField("modify_idp_status", label=_("修改认证源状态")) | |||
There was a problem hiding this comment.
ObjectTypeEnum 已经确定了操作的了行
那么 OperationEnum 只需要保留 增删改查， 不需要带资源类型
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
认证源 & 用户 相关操作审计
Checklist