-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
优化 bkapi-client-core 异常消息 #135
Merged
alex-smile
merged 13 commits into
TencentBlueKing:master
from
alex-smile:ft_raise_for_status
Nov 28, 2023
Merged
优化 bkapi-client-core 异常消息 #135
alex-smile
merged 13 commits into
TencentBlueKing:master
from
alex-smile:ft_raise_for_status
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
不暴露 check_response_status
wklken
approved these changes
Nov 20, 2023
Fix by review 1120 2
tFix by review 1120 3
Han-Ya-Jun
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wklken
approved these changes
Nov 22, 2023
zhu327
approved these changes
Nov 22, 2023
piglei
reviewed
Nov 30, 2023
@property | ||
def request_method(self): | ||
# type: (...) -> Optional[str] | ||
return self.request and self.request.method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:考虑改成三元表达式
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.