Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化 bkapi-client-core 异常消息 #135

Merged
merged 13 commits into from
Nov 28, 2023

Conversation

alex-smile
Copy link
Contributor

No description provided.

@alex-smile alex-smile requested a review from wklken November 20, 2023 09:21
sdks/bkapi-client-core/bkapi_client_core/utils.py Outdated Show resolved Hide resolved
sdks/bkapi-client-core/bkapi_client_core/client.py Outdated Show resolved Hide resolved
@wklken wklken self-requested a review November 20, 2023 12:17
Copy link
Member

@Han-Ya-Jun Han-Ya-Jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-smile alex-smile requested a review from zhu327 November 22, 2023 01:55
@alex-smile alex-smile merged commit c356392 into TencentBlueKing:master Nov 28, 2023
3 of 7 checks passed
@property
def request_method(self):
# type: (...) -> Optional[str]
return self.request and self.request.method
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:考虑改成三元表达式

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants