Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pull_kvs method #10

Merged
merged 2 commits into from
Dec 6, 2024
Merged

feat: add pull_kvs method #10

merged 2 commits into from
Dec 6, 2024

Conversation

ifooth
Copy link
Member

@ifooth ifooth commented Dec 5, 2024 •
edited
Loading

piglei
piglei approved these changes Dec 6, 2024
View reviewed changes
readme_en.md
@@ -58,6 +58,20 @@ For more sample code, please refer to the examples/ directory.

### Development Guide

Installation environment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit：英文翻译不太准确

bk_bscp/models.py
class AppOptions:
"""AppOptions options for app pull and watch"""

match: List[str] # Match matches config items
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit：考虑直接在类的 docstring 里面写字段说明

@ifooth ifooth merged commit 2348a1d into TencentBlueKing:master Dec 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piglei piglei piglei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifooth @piglei