Support for new twitch capabilities #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So just bumped up against this again, the above fix still appears to work just fails tests because the tests don't take into account twitch supporting capabilities. Any chance of this being looked at? |
|
@richardbenson is this something you still need/wanted? |
|
@VictorioBerra I still use Tennu and still with the same change made manually every time I update, I don't know how useful it is to others but without this patch you can't do anything interesting with Twitch's IRC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #76
Twitch now support capabilities, and have three available (https://dev.twitch.tv/docs/irc#twitch-capabilities) but they don't support multi-prefix (not does the channel plugin work)
This PR allows capability setting when daemon is set to twitch and doesn't require multi-prefix