Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace deprecated md5 assets with gooey from MawGooey #43

Merged
merged 5 commits into from
Nov 29, 2020
Merged

feat: replace deprecated md5 assets with gooey from MawGooey #43

merged 5 commits into from
Nov 29, 2020

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Nov 15, 2020 •
edited
Loading

  • Gooeys are moved into MawGooey module, use gltf model from there
  • gameplay specific assets like skins and textures for enemies stay

Depends on Terasology/Gooey#5

  • removes deprecated md5 assets
  • removes duplicated upper-case assets

@jdrueckert jdrueckert self-assigned this Nov 15, 2020
@jdrueckert jdrueckert mentioned this pull request Nov 15, 2020
Closed
32 tasks
skaldarnar
skaldarnar requested changes Nov 29, 2020
View reviewed changes
Copy link
Contributor

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no Gooeys visible in the wave, but the entities were definitely there as I've lost the game 🙈 probably the models were in the ground...

@jdrueckert
Copy link
Member Author

Gooeys should walk on the ground now.
They walk backwards, though, which as discussed in Discord is due to no rotation being applied in https://github.com/Terasology/GooeyDefence/blob/develop/src/main/java/org/terasology/gooeyDefence/movement/MovementSystem.java#L91.
I created #47 to track this.

skaldarnar
skaldarnar approved these changes Nov 29, 2020
View reviewed changes
Copy link
Contributor

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works ✔️

image

@jdrueckert jdrueckert merged commit ba8c5eb into develop Nov 29, 2020
@jdrueckert jdrueckert deleted the chore/replace-md5-with-gltf branch November 29, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar skaldarnar approved these changes

Assignees

@jdrueckert jdrueckert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrueckert @skaldarnar