Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed all weapons from starting inventory and made weapons purchasable #249

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

ujjman
Copy link
Member

@ujjman ujjman commented Nov 16, 2021

Fixes #248
This PR removes all weapons from starting inventory. It makes weapons purchaseable and attempts to balance them a bit better.
We do have different dimensions along which we can assess the (combat) value of a weapon:

  • range
  • damage
  • ammo requirements
  • cooldown
Weapon Range Ammo? Damage Cooldown Time to Kill Value
Sword 2 no 20-30 500 2000 50
Waraxe 2 no 40-60 1000 2000 50
Staff (Fireball) long infinite 10 300 3000 50
Spear (Melee) 4 no 20-30 1000 4000 50
Spear (Throw) long yes (self) 100 100 (slot change) 100 50
Crossbow (Arrows) long finite 20 200 1000 30 (1 per arrow)

Time to kill is ceil(playerMaxHealth / damage) * cooldown with playerMaxHealth = 100.
Starting money for players is 100.

Melee weapons - sword, axe (, staff, spear)

  • Con: need to get close to enemy
  • Pro: acceptable to high damage

Ranged, ammo-less weapons - staff (fireball)

  • Con: low damage, hard to hit opponent
  • Pro: endless ammo, acceptable cooldown, long range

Ranged, ammo-requiring weapons - Crossbow (arrows)

  • Con: requires ammo, hard to hit opponent
  • Pro: low cool down, acceptable damage, long range

Ranged, pick-up weapons - Spear (throw)

  • Con: needs to be picked up, hard to hit opponent
  • Pro: very high damage, long range

this PR removes all weapons from starting inventory therefore making weapons to be purchased
this commit makes the weapons purchasable
@ujjman ujjman changed the title removed all weapons from starting inventory removed all weapons from starting inventory and made weapons purchasable Nov 17, 2021
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some information to the PR description detailing why you chose the respective values for the different items? For instance, why does the waraxe cost twice as much as the sword or spear?

@jdrueckert jdrueckert self-assigned this Dec 4, 2021
@jdrueckert jdrueckert requested a review from skaldarnar December 4, 2021 19:48
@jdrueckert jdrueckert added Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Type: Improvement Request for or addition/enhancement of a feature labels Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Items from Starting Inventory to In-Game Shop
2 participants