Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add priority system for rail blocks #46

Merged
merged 2 commits into from
Jun 9, 2019
Merged

Add priority system for rail blocks #46

merged 2 commits into from
Jun 9, 2019

Conversation

mayant15
Copy link
Contributor

@mayant15 mayant15 commented Jun 7, 2019

When multiple blocks can be placed at a particular location, the module
now selects an appropriate one according to a specified priority order.

Also reformatted the code in RailBlockFamily.

Should fix #43 and #15

TO TEST:

  • Start a game with Rails enabled
  • Arrange the some rail blocks as shown in Cannot place sloped rail #43
  • Try to place the rail in between. A turn should be placed.

43

@mayant15
Add priority system
4d78ed3 
When multiple blocks can be placed at a particular location, the module
now selects an appropriate one according to a specified priority order.

Also reformatted the code in RailBlockFamily.
iaronaraujo
iaronaraujo approved these changes Jun 8, 2019
View reviewed changes
Copy link
Contributor

@iaronaraujo iaronaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get to test it ingame, but everything looks nice! I especially liked the small changes that improved the code quaility

iaronaraujo
iaronaraujo approved these changes Jun 9, 2019
View reviewed changes
Copy link
Contributor

@iaronaraujo iaronaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and everything is working! Nice job!

@iaronaraujo iaronaraujo merged commit a5a0b10 into Terasology:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iaronaraujo iaronaraujo iaronaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot place sloped rail
2 participants
@mayant15 @iaronaraujo