-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds EPSG:7855 to known projections. #6857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I can't remember much about this stuff, but is there a reason why some use of Reproject
uses the terriajs Proj4Definitions
instead of the terriajs-server proj4lookup
service?
For example - in GeoJsonMixin
the CRS needs to be in the proj4lookup
service in order to reproject features
terriajs/lib/ModelMixins/GeojsonMixin.ts
Lines 1436 to 1458 in ed7c97f
const needsReprojection = proj4ServiceBaseUrl | |
? await Reproject.checkProjection(proj4ServiceBaseUrl, code) | |
: false; | |
if (needsReprojection) { | |
try { | |
filterValue(geoJson, "coordinates", function (obj, prop) { | |
obj[prop] = filterArray(obj[prop], function (pts) { | |
if (pts.length === 0) return []; | |
return reprojectPointList(pts, code); | |
}); | |
}); | |
return geoJson; | |
} catch (e) { | |
throw TerriaError.from(e, "Failed to reproject geoJSON"); | |
} | |
} else { | |
throw new DeveloperError( | |
"The crs code for this datasource is unsupported." | |
); | |
} | |
} |
It might be worth adding EPSG:7855
to terriajs-server too
Also, this ties into the general issues with GDA2020 and GDA94 that we haven't resolved - in that the transformation from GDA2020 to WGS84, and GDA94 to WGS84 is null - but transformation from GDA94 to GDA2020 is not null.
But that is definitely for another day 🙂
Good observations @nf-s. I think the Also I think, the Reproject API could be rewritten as |
@nf-s terriajs-server change is here - TerriaJS/terriajs-server#150 |
What this PR does
Adds EPSG:7855 to known projections.
This should fix ideal zoom for some layers.
Test me
Check ideal zoom before and after
Checklist
doc/
.