Fix WMS null rectangle check + inherit bbox from ancestor WMS Layers
#6864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix WMS null rectangle check + inherit bbox from ancestor WMS
Layers
Fixes #6860
There was a bug that was causing
WebMapServiceCatalogItem.rectangle
to be{"west": 0,"south": 0,"east": 0,"north": 0}
which was breaking cesium internals. I fixed this with a null check.Additionally, in the WMS spec (for both 1.3.0 and 1.1.1), you can have a hierarchy of
Layers
and certain parent properties can be inherited by childLayers
- for exampleEX_GeographicBoundingBox
- which is used to calculaterectangle
. So I added ability to work up throughLayer
ancestors until aEX_GeographicBoundingBox
is found.In the test case below, the child
Layer
of interest doesn't have aEX_GeographicBoundingBox
, but it's parent does - so it should inherit it.Changes
WebMapServiceCatalogItem
rectangle
calculation - and now we ascend tree of WMSLayers
until we find a rectangle.Test me
main
test linkChecklist
I've updated relevant documentation indoc/
.