Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to work with Turbolinks 5 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aalbayaty
Copy link

Changed the headers to support Turbolink. To be more specific on all redirects adding "Turbolinks-Location".

@ghost
Copy link

ghost commented Aug 13, 2020

Any reason this can't be merged?

@dmorganb
Copy link

dmorganb commented Aug 16, 2020

I tried this and it didn't work as I expected when I had an action that returned a RedirectResult. The reason was that the turbolinks location header needs to be added at the last request(i.e. the GET request, after the REDIRECT) I am working on getting this to work

@dmorganb
Copy link

dmorganb commented Aug 20, 2020

In the end, it resulted in something different, so I created my own implementation: https://github.com/dmorganb/TurboLinksCore/blob/master/src/TurbolinksMiddleware.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants