PLA-873 #6
Merged
PLA-873 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther request classes
sepbot
reviewed
Jan 13, 2023
n1tsua
reviewed
Jan 17, 2023
n1tsua
reviewed
Jan 17, 2023
n1tsua
reviewed
Jan 17, 2023
n1tsua
reviewed
Jan 17, 2023
n1tsua
reviewed
Jan 17, 2023
n1tsua
reviewed
Jan 17, 2023
n1tsua
reviewed
Jan 17, 2023
n1tsua
reviewed
Jan 17, 2023
n1tsua
reviewed
Jan 17, 2023
| test("a JWT that tries to be sneaky and change the audience", async () => { | ||
| const request = new TestBoxUseCaseRequest(USE_CASE_REQUEST_BODY); | ||
| const jwtToken = | ||
| "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6IlRPTTRycTdySlNNdk5Gang2eEVIVXJScmVqU0lJcC9MZWtVWjhjVXhpaGs5bXh2T1FocGFaK1RQTUs5MkhYZFpvOTdmRzVqTHJUeHJRajFuZkdEVUhRPT0ifQ.eyJzdWIiOiIxMjM0NTY3ODkwIiwidHJpYWxfaWQiOiJjMzVkZDkxOS02ZGYzLTQ5Y2EtOTZkMC1kMzBlMTBkYmE0NDIiLCJhdWQiOiJ1bml0LXRlc3QtYnJva2VuIn0.F3-i0vXNUq4uDBX3YgSswiBSbqByPR0KxSrwuTBYdA1t8EWfPyFMXpxplIsXxCe26OrizIUoReuxKM_aAk9FTtWAuVmXYBKrSei77KpW2Vsp71SjglPgFFY6Wj_1BkTp2C1Z3iAjVBpfJOw5R0hNp18BrLBcg-iZ4XZL6LGUR2YHWPK2MqLDg6Yant_ZP_gIzPcW16UEleJFTGlbfh3Jsl47dQwisuWwiCUJb-7XO8bEQY6SFKZul36NQ4wU9qHnOiG27oEUwBR9LdXuqbJc3C3RLoPlDLS4SKjxAfp0SkejjuRqxPqFmSVJF9YbhrB_8gNwqWIEEffS2gUoIU3e4w"; |
There was a problem hiding this comment.
Do these JWTs have expiries? If they do, they might cause these tests to fail later on. We may need to live generate them
There was a problem hiding this comment.
I didnt find anything in the token or checking for expiration, so I would say they dont.
Also the tests for trial request had been running with fixed tokens for a while now.
n1tsua
reviewed
Jan 17, 2023
| app.use(bodyParser.json()); | ||
|
|
||
| app.post("/api/testbox/trial", async (req, res) => { | ||
| const trialRequest = await TestBoxTrialRequest.fromExpressRequest(req); |
There was a problem hiding this comment.
Don't need to change -- but since we have configured TestBox to be EXPRESS above, we would want this to just be TestBoxTrialRequest.fromRequest(request) or even just TestBoxTrialRequest(req)
n1tsua
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.