Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OIDC support, improved OAuth flow #262

Open
wants to merge 1 commit into
base: testlink_1_9
Choose a base branch
from

Conversation

epiclen
Copy link

@epiclen epiclen commented Apr 17, 2020

Added code to support Dex based authentication.

@squash-labs
Copy link

squash-labs bot commented Apr 17, 2020

Manage this branch in Squash

Test this branch here: https://epiclentestlink-1-9-52oru.squash.io

@epiclen epiclen force-pushed the testlink_1_9 branch 5 times, most recently from 0de6602 to 6052aa7 Compare April 17, 2020 08:47
@fmancardi
Copy link
Contributor

Hi:
would you mind providing some documentation regarding configuration?
also, instructions to set a testing environment will be great

@epiclen epiclen force-pushed the testlink_1_9 branch 3 times, most recently from 888d3d7 to dd38e28 Compare April 21, 2020 02:12
@epiclen
Copy link
Author

epiclen commented Apr 21, 2020

Hey @fmancardi
I added dex.md to describe how to configurate dex oauth.

@fmancardi
Copy link
Contributor

Thanks.
I know absolutely ZERO about DEX, then my question is:
there is some ONLINE Free server that can be used to test your implementation, the same way I can test OAuth with Microsoft, Azure, Google, Github?
I would like to do some tests before adding to stable code
thanks again

@epiclen
Copy link
Author

epiclen commented Apr 23, 2020

Dex is an identity service that uses OpenID Connect to drive authentication for other apps.
It`s usually uses to provide private authentication service.There is no public server.
https://github.com/dexidp/dex

@danielfbm
Copy link

danielfbm commented Apr 27, 2020

I understand that Dex mostly provides OpenID Connect authentication, so would this feature be able to use other OIDC providers like Keycloak, Auth0? If yes, can you do some quick testing using Auth0, maybe write down here the steps you took to test.

If it works for other OIDC providers, I believe is best to make it as an OIDC authentication mechanism, and not a vendor specific

@epiclen
Copy link
Author

epiclen commented Apr 27, 2020

@danielfbm
Sorry,this is my fault.As you say,"Dex mostly provides OpenID Connect authentication".It is not only support dex.
Dex is an identity service that uses OpenID Connect to drive authentication for other apps.
This pr actually add OpenID Connect support.
@fmancardi This feature also work with other oidc provider.

@epiclen epiclen changed the title Added Dex support, improved OAuth flow Added OIDC support, improved OAuth flow Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants