-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for updating build custom fields in XML-RPC API #47
Added support for updating build custom fields in XML-RPC API #47
Conversation
Added a function which is similar to updating testcase custom fields
@fmancardi can you please review this change? |
Hi On Mon, Aug 1, 2016 at 10:40 AM, Mohammad Azim Khan <
Francisco Mancardi |
Thanks for your reply. Didn't intend to bother you. Only reason was that this change is dependency to testlink-java-api -> testlink-plugin that is also modified. But anyways we have applied the changes locally. Hope you pick it up soon. Cheers |
'msg' => 'Custom Field:' . $cfName . ' skipped '); | ||
} | ||
|
||
return $ret; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ConorPKeegan Returning from within the loop will not process all the custom fields received.
All fields are processed before the result is returned
It is over a month now and related changes in jenkinsci/testlink-plugin#23 can not be accepted until this PR is merged. Really appreciate if this contribution is honoured in time. We have more changes lined up in testlink-plugin that we want to do on top of this. |
Again: |
I hope you understand there is maintenance effort in having our own fork and still wanting to get new releases. Secondly it is made worse by this PRs dependency in another useful plugin. |
IMHO this discussion here about how healthy is the support, is OFF TOPIC. In any case Testlink offers free best effort support, if you need a different kind of support you can ask for buying support |
Thanks! |
Changes
updateBuildCustomFieldsValues
toxmlrpc.class.php
to update build custom fields using XML-RPC. It is based on the functionupdateTestSuiteCustomFieldDesignValue
en_GB
, which relates to the new error code for the build not being linked to any custom fieldsDescription