Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let controller aware of computation nodes #2466

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Yicong-Huang
Copy link
Collaborator

@Yicong-Huang Yicong-Huang commented Mar 11, 2024

This PR lets the AmberClient pass the worker/computation node address information to a Controller of a specific execution through ControllerConfig.

@Yicong-Huang Yicong-Huang self-assigned this Mar 18, 2024
@Yicong-Huang Yicong-Huang added engine refactoring Refactor the code labels Mar 18, 2024
Copy link
Collaborator

@shengquan-ni shengquan-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine refactoring Refactor the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants